Fix crash when selecting same mod from different providers

[Trial97]

Fixes #1028

[Scrumplex]

Changes look okay. Need to test and reproduce the original issue though

[Trial97]

If it helps this is the log from my other PR: #986 (comment) credits @DioEgizio

[flowln]

instead of duplicating a list of selected mods (which already exists on ResourceDownloadDialog), i think it would make more sense to differentiate between selected mods for download and already downloaded mods in IndexedPack itself. Then, for some effects, like the selected indication, both types would have visual impact, whereas only the selected mods for download would show up in the confirmation page, for instance.

Note, however, that not only are you fixing a bug in this PR, you're also making a behavioral change in the downloader, by marking the already downloaded mods as selected. While I don't personally favor this feature, i'm not against it, but I think you should be more clear in what you're aiming to achieve in your PR.

Also, I'd like to ask you to please be careful to only clang-format the portions of the file you have actually touched, since it currently leaves a lot of noise when reviewing, due to the formatting changes :p

[Trial97]

• need to remove the extra list of selected mods
• removed the extra code regarding the downloaded mods

Regarding the clang-format, I let my editor(vscode) handle all the formatting right now.
In order to reduce the noise regarding the formating:

• should I open an extra PR preceding each of my PRs with only the modified files formatted(no code change; so first accept the format PR then the actual PR)
• or should I open a separate PR that adds a GitHub action that formats all the code using clang-format(this will be a massive PR as it will format all the files, and may create some conflicts with existing PRs; but after this initial PR is accepted this will ensure that all code is formatted)

[flowln]

• should I open an extra PR preceding each of my PRs with only the modified files formatted(no code change; so first accept the format PR then the actual PR)

• or should I open a separate PR that adds a GitHub action that formats all the code using clang-format(this will be a massive PR as it will format all the files, and may create some conflicts with existing PRs; but after this initial PR is accepted this will ensure that all code is formatted)

neither, you can use range-formatting to format only the selected lines, so you only format the lines you change (though idk if vscode has that option), or you can git add -p to only put the changes that actually matter in the commit instead of whole files. You also don't have to revert the formattings you have already done, just be mindful of them in the future is all i'm asking 🙂

also, you don't have to cherry-pick commits from one branch to another if they aren't dependent. When one of them gets merged into develop, you can then merge (or rebase) develop into your other branch (e.g. you don't have to cherry-pick the commits from this branch into your other PR's branch)

[Trial97]

Removed the need for an extra list in ResourceDownloadDialog, just needs some time to test the new implementation(I tested it )

[Ryex]

LGTM

[flowln]

cute-DUSET-2.mp4

This doesn't look quite right o.O
Qt 6.5.0, if it helps.

[Trial97]

The repaint issue should be addressed.

[Trial97]

Regarding the failing test, as I do not have a Windows machine, I cannot reproduce it.
Also, the same codebase was used in another PR open here and all the tests passed.

[Ryex]

Regarding the failing test, as I do not have a Windows machine, I cannot reproduce it. Also, the same codebase was used in another PR open here and all the tests passed.

That Task test is unfortunately a bit wonky and randomly fails in the CI. code should be fine.

[Scrumplex]

@flowln please take a look again, once you find the time :D

[flowln]

I couldn't find any issues this time. Great job! :D

please stop formatting everything in the documents please

[flowln]

I'll squash since the merge commits will make the history annoying to read in the future.