Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blocked mod laxCompare that ignores seperators, whitespace, and case #1054

Merged

Conversation

Ryex
Copy link
Contributor

@Ryex Ryex commented May 4, 2023

Fix #958

Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
@DioEgizio DioEgizio added this to the 7.0 milestone May 4, 2023
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
@Ryex Ryex changed the title Add an addtional blocked mod lax file name match with replaced with + Add blocked mod laxCompare that ignores seperators, whitespace, and case May 4, 2023
@Ryex
Copy link
Contributor Author

Ryex commented May 4, 2023

@DioEgizio I changed the approach if you would like to re-review

Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Haven't tested yet though

@Scrumplex Scrumplex self-requested a review May 6, 2023 06:31
@Scrumplex
Copy link
Member

Thanks!

@Scrumplex Scrumplex merged commit ce5bb29 into PrismLauncher:develop May 6, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocked Mods sometimes don't transfer correctly or validate hashes.
3 participants