Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a close button to the main toolbar when running on gamescope #1065

Merged
merged 2 commits into from Jun 26, 2023

Conversation

leia-uwu
Copy link
Contributor

i don't own a steam deck to test this, but it worked on a local gamescope session so ig it will also work on the steam deck

closes #522

@leia-uwu
Copy link
Contributor Author

(forgot to sign the commit lol)

@Scrumplex
Copy link
Member

I wonder if there is a more general solution. Perhaps we can somehow query if server-side decorations are present and add this action depending on that?

@leia-uwu
Copy link
Contributor Author

leia-uwu commented May 10, 2023

I wonder if there is a more general solution. Perhaps we can somehow query if server-side decorations are present and add this action depending on that?

hmm, gamescope only supports xwayland clients so idk :ioa:
when running natively on wayland qt adds client side decorations if theres no server side ones

@leia-uwu leia-uwu changed the title add a close button to the instance toolbar when running on gamescope add a close button to the main toolbar when running on gamescope May 17, 2023
@leia-uwu
Copy link
Contributor Author

i totally didn't do this pr while sleep deprived and wrote instance toolbar instead of main toolbar lmao

@Ryex
Copy link
Contributor

Ryex commented May 17, 2023

It actualy would be nice to detect the case of no window decorations to add the close button. I use tileing windows managers like bspwm without decorations from time to time, that would be a nice to have.

@getchoo getchoo added enhancement New feature or request question Further information is requested simple change labels Jun 12, 2023
@Scrumplex Scrumplex added this to the 8.0 milestone Jun 24, 2023
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just add a FIXME comment to make this more universal in the future

@DioEgizio DioEgizio modified the milestones: 8.0, 7.2 Jun 24, 2023
Co-authored-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Leo <leo3758@riseup.net>
@Scrumplex Scrumplex merged commit 4d49486 into PrismLauncher:develop Jun 26, 2023
14 checks passed
@Scrumplex Scrumplex added the manual backport PRs that have been backported manually label Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request manual backport PRs that have been backported manually question Further information is requested simple change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a close button to the toolbar in the main GUI
5 participants