1.20 allowed_symlinks.txt support when copying with links #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…via symlinks Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
…ain) Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
DioEgizio
approved these changes
Jun 3, 2023
Scrumplex
reviewed
Jun 3, 2023
Scrumplex
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appends the old instance game root path to
allowed_symlinks.txtand ensures that the file itself is not a link.it does this regardless of if the Minecraft version supports 1.20 but IMO this is ok as the file's presence will not break anything and it supports Minecraft version upgrading if the user chooses to do that.
also noticed a bug in the copy task's save copy function (I guess my first attempt was a bit naive and no one caught it :P)
should clear up any concerns with the functionality of #833 in the soon to be released 1.20