Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed requires #1111

Merged
merged 2 commits into from Jun 7, 2023
Merged

Renamed requires #1111

merged 2 commits into from Jun 7, 2023

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Jun 6, 2023

Now that the requires is a keyword in C++20 I get a warning regarding that:

In file included from ~/.cache/paru/clone/prismlauncher-git/src/PrismLauncher/launcher/meta/Version.h:26,
                 from ~/.cache/paru/clone/prismlauncher-git/src/PrismLauncher/launcher/meta/VersionList.h:23,
                 from ~/.cache/paru/clone/prismlauncher-git/src/PrismLauncher/launcher/meta/Index.h:22,
                 from ~/.cache/paru/clone/prismlauncher-git/src/PrismLauncher/tests/Index_test.cpp:3:
~/.cache/paru/clone/prismlauncher-git/src/PrismLauncher/launcher/minecraft/VersionFile.h:141:22: warning: identifier ‘requires’ is a keyword in C++20 [-Wc++20-compat]
  141 |     Meta::RequireSet requires;
      |                      ^~~~~~~~

This PR resolves the mentioned warnings

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Scrumplex Scrumplex added this to the 7.0 milestone Jun 7, 2023
@Scrumplex Scrumplex added the enhancement New feature or request label Jun 7, 2023
@TayouVR TayouVR merged commit 9b9d439 into PrismLauncher:develop Jun 7, 2023
14 checks passed
@Trial97 Trial97 deleted the requires branch June 24, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants