Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various UI tweaks #1324

Merged
merged 6 commits into from Aug 10, 2023
Merged

Various UI tweaks #1324

merged 6 commits into from Aug 10, 2023

Conversation

leia-uwu
Copy link
Contributor

@leia-uwu leia-uwu commented Jul 7, 2023

I wanted to do more stuff but got lazy lol
Anyway, heres what i did:
All the browse files button text is now "Browse" instead of some being "Browse...", "Browse" or just "..."
The instance and global java settings UI are more consistent and have a better layout
Global java page:
Before:
image
After:
image
Instance java page:
Before:
image
After:
image

The page container list view has a property that makes Breeze and other qstyles aware that its a sidebar so they hide the ugly outline
Before/After:
image

And i also enabled tearing off the widebar context menu so you can pop it off on a window to easily toggle the checkboxes without reopening the menu each time

Signed-off-by: leo78913 <leo3758@riseup.net>
With this the sidebars look better with the breeze theme

Signed-off-by: leo78913 <leo3758@riseup.net>
Signed-off-by: leo78913 <leo3758@riseup.net>
@Scrumplex Scrumplex added this to the 7.3 milestone Jul 7, 2023
@Scrumplex Scrumplex added enhancement New feature or request ui rework labels Jul 7, 2023
@TheKodeToad
Copy link
Member

Initial thoughts:
maybe enable tear-off for show/hide columns?

image
this looks pretty nice at the top but not so much at the bottom

@TheKodeToad
Copy link
Member

The tear-off menu also kind of breaks when you switch pages

@leia-uwu
Copy link
Contributor Author

leia-uwu commented Jul 7, 2023

this looks pretty nice at the top but not so much at the bottom

hmm idk, this is the same property kde uses on its apps, but they don't have buttons and stuff bellow the list
image

i think it still looks better than the ugly frame outline

@leia-uwu
Copy link
Contributor Author

leia-uwu commented Jul 7, 2023

maybe enable tear-off for show/hide columns?

hmm k, ig i will also fix being able to disable all columns

@leia-uwu
Copy link
Contributor Author

leia-uwu commented Jul 7, 2023

for some reason enabling tear off on the columns context menu doesn't work...
/shrug

@TheKodeToad
Copy link
Member

i think it still looks better than the ugly frame outline

Maybe move the buttons then or have something like VirtualBox with padding

image

Signed-off-by: leo78913 <leo3758@riseup.net>
@leia-uwu
Copy link
Contributor Author

leia-uwu commented Jul 7, 2023

hmm i think it looks even worse and less modern with the padding lul

@TheKodeToad
Copy link
Member

Once #1320 is merged there'll be more space so I think the help button should be moved and container be extended?

if that's possible without a lot of change :p

@getchoo getchoo self-requested a review July 8, 2023 00:27
@TheKodeToad
Copy link
Member

image

I think this should be changed.

@leia-uwu
Copy link
Contributor Author

oops, i forgor about this one

Signed-off-by: leo78913 <leo3758@riseup.net>
@TheKodeToad
Copy link
Member

heh. not exactly obvious.

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, but i agree with toad on waiting for #1320

maybe we should move this to 8.0? 🤔

@TheKodeToad
Copy link
Member

It's the only thing on the 7.3 milestone, that probably makes sense

@getchoo
Copy link
Member

getchoo commented Jul 15, 2023

It's the only thing on the 7.3 milestone, that probably makes sense

i didn't even realize that :p
changing the milestone now

@getchoo getchoo modified the milestones: 7.3, 8.0 Jul 15, 2023
@TheKodeToad
Copy link
Member

hmm, i feel like tear-off isn't the best solution :/

@leia-uwu
Copy link
Contributor Author

hmm, i feel like tear-off isn't the best solution :/

hmm i was thinking of maybe just adding an "edit toolbar" entry to the context menu that opens a pop up with the action toggles

@TheKodeToad
Copy link
Member

I think having the menu stay open by default would be best, but may be hard with Qt :/

@leia-uwu
Copy link
Contributor Author

its not that hard
we can just make a class that extends qmenu and overrides some events iirc, i tried it before and it worked but i thought it was a bit of a hack so didn't pr it lol

@leia-uwu
Copy link
Contributor Author

@Scrumplex Scrumplex changed the base branch from develop to staging August 4, 2023 18:25
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex Scrumplex merged commit 2090f95 into PrismLauncher:staging Aug 10, 2023
4 checks passed
@Scrumplex Scrumplex added the changelog:changed A PR that appears under "Changed" in the changelog label Aug 18, 2023
@Scrumplex Scrumplex changed the title Some random small ui tweaks :p Various UI tweaks Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:changed A PR that appears under "Changed" in the changelog enhancement New feature or request ui rework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants