feat: made spent time format configurable

[Trial97]

fixes #554

Small changes that differ from the requirement:

• Days:
  • %d full amount of days (rounded down). Example: "3"
  • %d.1: full amount of days, with 1 digit of precision. Example: "3.2"
  • %d.2: full amount of days, with 2 digits of precision. Example: "3.18"
• Hours:
  • %h: amount of hours (full days deducted) (rounded down). Example: "4"
  • %h.1: amount of hours (full days deducted), with 1 digit of precision. Example: "4.4"
  • %h.2: amount of hours (full days deducted), with 2 digits of precision. Example: "4.43"
  • %H: full amount of hours (rounded down). Example: "76"
  • %H.1: full amount of hours, with 1 digit of precision. Example: "76.4"
  • %H.2: full amount of hours, with 2 digits of precision. Example: "76.43"
• Minutes:
  • %m: amount of minutes (full days and full hours deducted) Example: "26"
  • %M: full amount of minutes. Example: "4586"
• Seconds:
  • %s: amount of seconds (full days, full hours deducted,and full minutes deducted) Example: "26"
  • %S: full amount of seconds. Example: "4586"

The precision can be set exactly by suffixing the option with a dot and the wanted precision, e.g. %d.4 => days with digits of precision.

[getchoo]

i really like this! a few suggestions though:

• validate GameTimeFormat
  • this prevents issues where a user may have input improper or invalid formatting and having weird things appear in the ui. i think it would be best to revert back to the defaults in this case
• maybe ignore the GameTimeFormat when it doesn't apply to the given instance
  • in cases where i only specify %d%d, the total played: line has no characters following it. i think it would be best to revert back to the default here as well or try to convert the playtime to that format; another solution could be to allow for per instance configuration. imo reverting to the default or converting to the measurement specified by the formatting string would be the best option here, while still being pretty simple
• simply the syntax
  • similar to date in linux, i think just specifying %d for day, %h for hour, %m for minute, and %s for seconds would make more sense. using the same character twice in most cases (while also having two different formatting strings only for minutes) is a little odd to me and i don't believe it's something users would do on purpose a lot of the time

[Trial97]

Made most of the suggested changes. Here are some small notes:

• I kept the extra options(%H,%M, and %S) as they are used when you want to display the duration in that respective unit only, they are meant to be used together with precision (also they are a requirement from the issue)
• this format should be similar to the date in linux with the additions of the extra options and controllable precision
• now if the format is empty it fallbacks to the default format
• if the result is empty because of the trimmed zero values the function is recalled but keeps the zero everywhere(

  PrismLauncher/tests/Time_test.cpp

  Line 46 in b9b5195

  { 30, "%dd %hh %mmin", "0d 0h 0min" },

  )
• I did not do validation as I think is unnecessary, if the format is not empty and doesn't contain any known options the text will be printed as is, missing only the group of options that are not valid( the character '%' and the next one)

  PrismLauncher/tests/Time_test.cpp

  Lines 57 to 60 in b9b5195

  	{ 90, "custom text", "custom text" },
  	{ 90, "custom text =%p=", "custom text ==" },
  	{ 90, "custom text =%p.12=", "custom text ==" },
  	{ 90, "custom text =%p.=", "custom text =.=" },

[Scrumplex]

I don't think we need this much granularity for this, though? I think a simple checkbox to show the playtime in hours is fine.

[Trial97]

fair: I will close this after I open the other one

[Trial97]

closing this in favor of:#1536

[victorleblais]

I still think this would be neat as an advanced/optional feature that could be hidden behind a dropdown (with three options: days/hours, just hours, or "advanced", which shows the text input below the dropdown to type a custom format).

I always like having more options, but it's fine if they're hidden behind more clicks in order to keep the "basic behaviors" quick and accessible.

[Scrumplex]

I still think this would be neat as an advanced/optional feature that could be hidden behind a dropdown (with three options: days/hours, just hours, or "advanced", which shows the text input below the dropdown to type a custom format).

I always like having more options, but it's fine if they're hidden behind more clicks in order to keep the "basic behaviors" quick and accessible.

Advanced users can just go and extract the play time in seconds from the instance.cfg file and do whatever they want with that.