Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring amount of concurrent tasks #1363

Merged
merged 5 commits into from Sep 28, 2023
Merged

Allow configuring amount of concurrent tasks #1363

merged 5 commits into from Sep 28, 2023

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Jul 14, 2023 •
edited

from: #1305 (comment)

something that would be nice to add to this. the ability to configure / pull the max concurrency from a setting. (ie to configure max concurrent downloads).

the resent issue about it made be think of this work.

Adds two settings that allow the user to control:

  • the number of concurrent tasks
  • the number of concurrent network requests

@Trial97
made the number of concurrent tasks configurable
cebb4dd 
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@TheKodeToad
Copy link
Member

nice! someone on Discord was asking whether this was possible

@TheKodeToad
Copy link
Member

I'm guessing there was a smart reason to have some tasks using 6, and others 10.

Maybe you should have a separate network setting?

@Trial97
Copy link
Member Author

Trial97 commented Jul 14, 2023

Should I split that up into two configs then?
Obviously, I also need to fix the tests.

Ryex
Ryex suggested changes Jul 14, 2023
View reviewed changes
launcher/tasks/ConcurrentTask.h Outdated Show resolved Hide resolved
@TheKodeToad
Copy link
Member

Should I split that up into two configs then? Obviously, I also need to fix the tests.

If you also think it's a good idea :D

@Trial97
Split in two the options
db9f5f4 
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97
fixed tests
149b6d5 
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97
Merge branch 'develop' of https://github.com/PrismLauncher/PrismLauncher
b2fdd83 
 into download_threads

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 added enhancement New feature or request changelog:added A PR that appears under "Added" in the changelog labels Aug 12, 2023
@Trial97
Merge branch 'develop' of https://github.com/PrismLauncher/PrismLauncher
cf27d2f 
 into download_threads

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@DioEgizio DioEgizio added this to the 8.0 milestone Aug 27, 2023
@DioEgizio DioEgizio requested a review from Ryex August 27, 2023 14:56
@Trial97 Trial97 removed the request for review from Ryex September 28, 2023 19:18
@Scrumplex Scrumplex merged commit 2ff9ef0 into PrismLauncher:develop Sep 28, 2023
26 checks passed
@Scrumplex Scrumplex changed the title made the number of concurrent tasks configurable Allow configuring amount of concurrent tasks Sep 28, 2023
@Trial97 Trial97 deleted the download_threads branch September 29, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheKodeToad TheKodeToad TheKodeToad approved these changes

@Ryex Ryex Ryex requested changes

@DioEgizio DioEgizio DioEgizio approved these changes

Assignees
No one assigned
Labels
changelog:added A PR that appears under "Added" in the changelog enhancement New feature or request
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Trial97 @TheKodeToad @Ryex @DioEgizio @Scrumplex