Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links and add images to modpack changelogs #1370

Merged
merged 2 commits into from Aug 5, 2023
Merged

Fix links and add images to modpack changelogs #1370

merged 2 commits into from Aug 5, 2023

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Jul 15, 2023

fixes #615

@Trial97
Upgraded pack changelog
a3ffa64 
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@TheKodeToad TheKodeToad added this to the 8.0 milestone Aug 5, 2023
TayouVR
TayouVR approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@TayouVR TayouVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works!

@TayouVR TayouVR added the changelog:changed A PR that appears under "Changed" in the changelog label Aug 5, 2023
@TayouVR TayouVR changed the title Upgraded pack changelog Open links in modpack changelogs with System URL handler (web browser) Aug 5, 2023
@TheKodeToad TheKodeToad changed the title Open links in modpack changelogs with System URL handler (web browser) Fix links and add images to modpack changelogs Aug 5, 2023
@Scrumplex Scrumplex merged commit 7c547f6 into PrismLauncher:develop Aug 5, 2023
23 of 27 checks passed
@Trial97 Trial97 deleted the pack_changelog branch September 29, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scrumplex Scrumplex Scrumplex approved these changes

@TayouVR TayouVR TayouVR approved these changes

@TheKodeToad TheKodeToad TheKodeToad approved these changes

Assignees
No one assigned
Labels
changelog:changed A PR that appears under "Changed" in the changelog simple change ui rework
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

in the pack changelog viewer images aren't displayed and links don't work
5 participants
@Trial97 @Scrumplex @TayouVR @TheKodeToad @getchoo