New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added welcome screen #1374
Added welcome screen #1374
Conversation
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
A little too rough, it should be improved aesthetically in my opinion, but it is still a nice addition. |
Personally I'd just have "No instances :(" |
Yes I know is a crude implementation(is hard to paint with code). |
Oh, that's very ironic as this is literally based on my mockup 🤦♀️ |
Idk. I think I find the icon weird 😵💫 |
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Why is the background solid black? The contrast is definitely too much. |
It's the theme |
This text doesn't actually tell one what they need to do to add an instance, so it's kind of useless |
Right now I'm open to any suggestions, if you can provide a better language for that or a mockup of how the page should look like I would try to implement it |
Maybe something like "Right click anywhere to create an instance.". The text should be only a little bit lighter than the background, just enough so to be visible. It should also be vertically centered. |
There's a fairly obvious button. Also lowering contrast is a bad idea imo. |
This text is supposed to be a subtle hint, not a screaming reminder. In all software such a text is present, it doesn't contrast so much with the background it's on. Making it so big and so bright would be a definite UX issue. |
Also please note this screen will be visible only if the number of instances is zero. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is more useful.
also i think it's too big and the text should be smaller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i didn't add that to the review. oops
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks kinda bad but better than not having anything ig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
considering how annoying it is to work within this code, LGTM
(whenever we revamp the instanceview fully (#30) maybe this could get changed to look nicer, be centered vertically, etc.)
@RokeJulianLockhart can you comment instead of just downvoting? |
@TheKodeToad, what do you refer to? |
I know that. I ask which comment you refer to, @TheKodeToad. |
fixes #827