Fix transparency in skin icon

[lumiscosity]

QPainter has a bug where drawing transparency to a freshly initialized, empty QPixmap causes garbage data to be drawn. This broke the rendering of the skin icon. The fix is simply to fill the QPixmap with empty transparent pixels beforehand.

Signed-off-by: lumiscosity averyrudelphe@gmail.com

[TheKodeToad]

Just a suggestion, if you want to keep it the same please format it

[lumiscosity]

sorry, i wasn't aware such a constant existed! it's been added now

[TheKodeToad]

You forgot to sign off your commits :P
Edit: I don't know what that is about

[Trial97]

Maybe its because of some GitHub shenanigans maple! vs lumiscosity :
in the first commit the signoff is with maple! but for the rest is lumiscosity

From DCO error message:

[lumiscosity]

could be; i manually amended the first commit to include the signoff text, and the latter two were accepted with github's "Sign off and commit suggestion" button. sorry, i've never made a pr before

[Scrumplex]

sorry, i've never made a pr before

Don't worry about it :D

It is quite unintuitive honestly

Thanks for your contribution, either way :D

[Scrumplex]

when taking a look at the log, your first commit was authored by maple! while the sign off says lumiscosity. The latter should also be maple!, so ideally amend it again and change lumiscosity to maple!

[lumiscosity]

alright, i asked a friend who's more knowledgeable about this stuff who told me to just wipe the whole thing and recommit it. should be fine now

[TheKodeToad]

I think we're waiting for #1486 to be merged before merging any prs targetting develop

[Scrumplex]

this should fix the build on the older Qt 5 version used in one of the Linux builds

[Scrumplex]

cough

[TheKodeToad]

oh, I forgot we were using older qt versions than that