More system properties #1515
Merged
More system properties #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
getchoo
reviewed
Aug 11, 2023
getchoo
added
enhancement
Scrumplex
reviewed
Aug 15, 2023
TheKodeToad
changed the title
Trial97
approved these changes
Oct 15, 2023
|
If this could get approved before Oct 26th 2023, I can happily support this within CraftPresence's PrismLauncher pack implementation. As Oct 26th is the planned release date for the upcoming v2.2.4 patch for my mod |
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
|
is it still a good idea to support MultiMC properties? maybe it makes sense as we are a fork |
|
@TheKodeToad Personally, I think it would be nice, at least to preserve compatibility with its variables, if other mods decide to utilize those variables. |
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Scrumplex
approved these changes
Oct 22, 2023
getchoo
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(CraftPresence already reads the instance.cfg file but adding multimc's props is a small optimisation that's already implemented)