Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added check for valid query items in curse url install #1557

Merged
merged 1 commit into from Aug 21, 2023

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Aug 21, 2023

Parent PR: #981

This fixes a crash with the curseforge URL handler where if addonId or fileId is missing from a given link the app crashes.
e.g. prismlauncher 'curseforge://install?addonId=486989'

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 added bug Something isn't working simple change changelog:fixed A PR that appears under "Fixed" in the changelog labels Aug 21, 2023
@Scrumplex Scrumplex added changelog:merged A PR that will be merged into a parent PR in the changelog and removed changelog:fixed A PR that appears under "Fixed" in the changelog labels Aug 21, 2023
@Scrumplex Scrumplex added this to the 8.0 milestone Aug 21, 2023
@Scrumplex Scrumplex merged commit b1783d8 into PrismLauncher:develop Aug 21, 2023
36 checks passed
@Trial97 Trial97 deleted the curse_crash branch September 29, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog:merged A PR that will be merged into a parent PR in the changelog simple change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants