Fully reload the instance list once the folder is changed

[Trial97]

fixes #1584

[TheKodeToad]

All of the instances are removed for me

[TayouVR]

it works for me...

[Trial97]

All of the instances are removed for me

I want to try to reproduce this, can you describe the steps?

[TheKodeToad]

I mean without this PR it's already removing instances for me

[Trial97]

Well obviously that already happens, what doesn't happen is:

• if you have two instance folders and have an instance with the same id
• switch between them in the settings menu( without restarting the launcher)
• trying to start the instance with the same name would result in using the old one if the previous path is still valid, if the instance is no longer there, you will get the same prompt as in the linked issue

My test method for this was:

• open prism
• go to prism root folder
• rename the instances folder to instances2
• go into prism settings and change the folder to instances2
• try to start an instance

[TayouVR]

huh, after some more testing....
This PR still works perfectly.
But on the develop branch build I have installed it just crashes... without any obvious indicator of what is happening.. might run a debugger on it at some point, though I have like no time at all right now and for the coming days
Didn't test the ID thing specifically, but yeah....

EDIT: reworded it a tiny bit to make it more clear

Mentione of some crash with current implementation

[Trial97]

EDIT: reworded it a tiny bit to make it more clear

I'm confused now does this PR crashes or not?
I removed your approval because I thought that the crash was related to my PR. Can you approve it again if it is not the case?

[TayouVR]

the develop branch had a crash in my testing, the PR didn't. hence I tried to clarify the comment.
But as stated I need to see what is actually happening.. when i have time (I have job interviews and other appointments every day until friday next week, so I have to see if I can squeeze some debugging in somewhere)