Added version check for neoforge filter #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Trial97
added
enhancement
getchoo
approved these changes
Sep 30, 2023
|
I don't think this version comparison works with snapshots (and I wouldn't actually be surprised if they are supported in future at this point lol) |
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
|
It looks like that would not be a problem the Version class can handle the snapshots stuff. |
|
I'm talking about the [year]w[week][a-z] format |
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
|
Ok, I added a more strict condition: the forge is added just for 1.20.1. |
TheKodeToad
reviewed
Oct 6, 2023
Co-authored-by: TheKodeToad <TheKodeToad@proton.me> Signed-off-by: Alexandru Ionut Tripon <alexandru.tripon97@gmail.com>
TheKodeToad
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the neoforge loaders filter dependent on the instance version.
Currently, 1.20.1 is compatible with the forge, but with 1.20.2 the compatibility is dropped.