Localize account type in account list #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrumplex
approved these changes
Oct 26, 2023
Trial97
reviewed
Oct 26, 2023
Signed-off-by: LocalSpook <56512186+LocalSpook@users.noreply.github.com>
LocalSpook
force-pushed
the
account_type
branch
from
ca4d617
to
9d972cc
Compare
Trial97
approved these changes
Nov 23, 2023
Scrumplex
approved these changes
Nov 23, 2023
Scrumplex
added
changelog:changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the account type (MSA or offline) in the account list view was not translated.
Before:
After:
Note: I mucked around a bit in
launcher/minecraft/auth/MinecraftAccount.h, replacing the twoisMSA()andisOffline()functions with oneaccountType()function. If those changes aren't desirable for whatever reason I can revert them.