Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try refreshing account on launch if needed #1771

Merged
merged 6 commits into from Jan 10, 2024
Merged

Try refreshing account on launch if needed #1771

merged 6 commits into from Jan 10, 2024

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Oct 30, 2023 •
edited

fixes #920
fixes #592
fixes #520
fixes #293
maybe #699 (not sure but looks similar)

This is the same as #1558 but it's ready to review( and also the mentioned PR did not have any activity for some time)

A good way to test this:

  • stop your internet(disable the wifi)
  • start prism
  • check if you are prompted with the offline dialog when you try to start an instance( you do not need to start it)
  • connect to internet
  • start a instance
  • you should not be prompted with anything starting the game online

@Trial97
fixed account refresh after sleep
7166d68 
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 added bug Something isn't working simple change changelog:fixed A PR that appears under "Fixed" in the changelog labels Oct 30, 2023
@Trial97 Trial97 added this to the 8.1 milestone Oct 30, 2023
@Trial97
moved refresh out of the loop
2863a69 
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 mentioned this pull request Nov 16, 2023
Closed
1 task
Scrumplex
Scrumplex reviewed Nov 23, 2023
View reviewed changes
launcher/LaunchController.cpp Outdated Show resolved Hide resolved
launcher/LaunchController.cpp Outdated Show resolved Hide resolved
@Trial97
Fixed localization stuff
9345416 
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Scrumplex Scrumplex added the backport release-8.x Backport PR automatically label Dec 11, 2023
@Trial97
Removed auto reauthenticate
400b518 
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 mentioned this pull request Dec 13, 2023
Open
@Scrumplex Scrumplex changed the title fixed account refresh after sleep Try refreshing account on launch, if needed Dec 16, 2023
@Scrumplex Scrumplex changed the title Try refreshing account on launch, if needed Try refreshing account on launch if needed Dec 16, 2023
@Trial97 Trial97 merged commit dbdec15 into PrismLauncher:develop Jan 10, 2024
31 checks passed
@Trial97 Trial97 deleted the account branch January 10, 2024 14:07
@github-actions GitHub Actions
Copy link
Contributor

Backport failed because this pull request contains merge commits. You can either backport this pull request manually, or configure the action to skip merge commits.

@Trial97 Trial97 restored the account branch January 10, 2024 14:07
@Trial97 Trial97 added manual backport PRs that have been backported manually and removed backport release-8.x Backport PR automatically labels Jan 10, 2024
Trial97 added a commit to Trial97/PrismLauncher that referenced this pull request Jan 10, 2024
@Trial97
Merge pull request PrismLauncher#1771 from Trial97/account
422135b 
Try refreshing account on launch if needed
@Trial97 Trial97 mentioned this pull request Jan 11, 2024
Closed
LunaisLazier pushed a commit to LunaisLazier/ShatteredPrism that referenced this pull request Feb 9, 2024
@Trial97 @LunaisLazier
Merge pull request PrismLauncher#1771 from Trial97/account
a19a2bc 
Try refreshing account on launch if needed
LunaisLazier added a commit to LunaisLazier/ShatteredPrism that referenced this pull request Feb 10, 2024
@LunaisLazier
Revert "Merge pull request PrismLauncher#1771 from Trial97/account"
562a668 
This reverts commit a19a2bc.
@Scrumplex Scrumplex added changelog:changed A PR that appears under "Changed" in the changelog and removed changelog:fixed A PR that appears under "Fixed" in the changelog labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scrumplex Scrumplex Scrumplex approved these changes

@getchoo getchoo getchoo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working changelog:changed A PR that appears under "Changed" in the changelog manual backport PRs that have been backported manually simple change
Projects
None yet
Milestone
8.1
3 participants
@Trial97 @Scrumplex @getchoo