Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Autodetect Java from the Microsoft Store version of the official launcher #1798

Merged
merged 2 commits into from Nov 12, 2023
Merged

[Windows] Autodetect Java from the Microsoft Store version of the official launcher #1798

merged 2 commits into from Nov 12, 2023

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Nov 7, 2023 •
edited by Scrumplex

fixes #1835
issue reported: Minecraft java detection not working on windows: https://discord.com/channels/1031648380885147709/1167762562155303014/1171227351774937150
Microsoft uses two paths for this:

  • on UNIX inside the .minecraft data dir
  • on Windows is where Minecraft is installed.

@Trial97
added additional minecraft java path for windows
c78d35d 
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 added bug Something isn't working simple change changelog:merged A PR that will be merged into a parent PR in the changelog labels Nov 7, 2023
@Trial97 Trial97 added this to the 8.0 milestone Nov 7, 2023
@Trial97 Trial97 added the needs-testing PRs that should be tested a bit more before being merged label Nov 7, 2023
@Trial97 Trial97 modified the milestones: 8.0, 8.1 Nov 7, 2023
getchoo
getchoo requested changes Nov 8, 2023
View reviewed changes
launcher/java/JavaUtils.cpp Outdated Show resolved Hide resolved
@Trial97 @getchoo
Update launcher/java/JavaUtils.cpp
7313630 
Co-authored-by: seth <getchoo@tuta.io>
Signed-off-by: Alexandru Ionut Tripon <alexandru.tripon97@gmail.com>
@getchoo
Copy link
Member

getchoo commented Nov 8, 2023

image
works as expected

@getchoo getchoo removed the needs-testing PRs that should be tested a bit more before being merged label Nov 8, 2023
@getchoo getchoo changed the title added additional minecraft java path for windows [Windows] Autodetect Java from the Microsoft Store version of the official launcher Nov 8, 2023
TayouVR
TayouVR approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@TayouVR TayouVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't test it due to MS Store fuckery, but it seems to work, so LGTM.

@TayouVR TayouVR merged commit a991d48 into PrismLauncher:develop Nov 12, 2023
31 checks passed
@Scrumplex Scrumplex added the manual backport PRs that have been backported manually label Nov 28, 2023
@Scrumplex Scrumplex added changelog:added A PR that appears under "Added" in the changelog and removed changelog:merged A PR that will be merged into a parent PR in the changelog labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TayouVR TayouVR TayouVR approved these changes

@getchoo getchoo getchoo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working changelog:added A PR that appears under "Added" in the changelog manual backport PRs that have been backported manually simple change
Projects
None yet
Milestone
8.1
Development

Successfully merging this pull request may close these issues.

Official launcher Java doesn't get autodetected
4 participants
@Trial97 @getchoo @TayouVR @Scrumplex