Improve Microsoft login flow #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Trial97
added
enhancement
TayouVR
approved these changes
Nov 7, 2023
Co-authored-by: Tayou <git@tayou.org> Signed-off-by: Alexandru Ionut Tripon <alexandru.tripon97@gmail.com>
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Co-authored-by: seth <getchoo@tuta.io> Signed-off-by: Alexandru Ionut Tripon <alexandru.tripon97@gmail.com>
getchoo
approved these changes
Nov 8, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
Scrumplex
approved these changes
Nov 8, 2023
Scrumplex
added
changelog:changed
|
wouldn't it be better to have a button instead of opening the browser straight away |
|
Not really as I want to simplify the process. not keep it the same. |
|
ig it's fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stolen from TheKodeToad from here: https://discord.com/channels/1031648380885147709/1031823065937629267/1171229791513493544
Please don't hesitate to suggest any text changes.
I kept the old behavior in case the user browser was not open or something was unclear.
Also tested and it works.