Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Linux] Added warning when /tmp directory is mounted with noexec #1882

Merged
merged 2 commits into from Nov 28, 2023
Merged

[Linux] Added warning when /tmp directory is mounted with noexec #1882

merged 2 commits into from Nov 28, 2023

Conversation

bit69tream
Copy link
Contributor

Minecraft versions starting from 1.19 would not start at all if /tmp is mounted as noexec.

Now, Prism Launcher will check if /tmp has noexec and if it does, a message pop-up like this would be displayed:

22-11-23--01-35-51

The C API for querying information about mount points is a bit ugly, but the only other option is to either parse /etc/mtab file or output of the mount command.

@bit69tream
(PrismLauncher#1693) Notify user if /tmp directory has noexec mount…
681e76c 
… option

Minecraft versions starting from 1.19 would not start at all if /tmp is mounted as `noexec`.

Signed-off-by: bit6tream <megapixel483@gmail.com>
@Scrumplex
Copy link
Member

Looks like it's safe to assume that LWJGL is going to use /tmp by default, as it uses java.io.tmpdir. See https://stackoverflow.com/a/1924576 https://github.com/LWJGL/lwjgl3/blob/ad602750ad87939276d1889b28a757061e90715b/modules/lwjgl/core/src/main/java/org/lwjgl/system/Configuration.java#L81-L106

Scrumplex
Scrumplex reviewed Nov 23, 2023
View reviewed changes
launcher/Application.cpp Outdated Show resolved Hide resolved
@bit69tream
(PrismLauncher#1693) Use a better approach to detect a noexec mount o…
d414599 
…ption

Signed-off-by: bit6tream <megapixel483@gmail.com>
@Scrumplex
Copy link
Member

Isn't statvfs available on the other two platforms? I thought it was :O

@bit69tream
Copy link
Contributor Author

bit69tream commented Nov 23, 2023 •
edited

Isn't statvfs available on the other two platforms? I thought it was :O

It is, but there are only ST_RDONLY and ST_NOSUID flags on both OpenBSD and FreeBSD.

@Scrumplex Scrumplex added this to the 8.1 milestone Nov 28, 2023
@Scrumplex Scrumplex added the changelog:added A PR that appears under "Added" in the changelog label Nov 28, 2023
@Scrumplex Scrumplex changed the title (#1693) Notify user if /tmp directory has noexec mount option [Linux] Added warning when /tmp directory is mounted with noexec Nov 28, 2023
@Scrumplex Scrumplex linked an issue Nov 28, 2023 that may be closed by this pull request
Could not initialize class com.mojang.blaze3d.systems.RenderSystem starting from 1.19 #1693
Closed
1 task
@Scrumplex Scrumplex merged commit 4c59a1b into PrismLauncher:develop Nov 28, 2023
32 of 38 checks passed
@Scrumplex Scrumplex added the manual backport PRs that have been backported manually label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scrumplex Scrumplex Scrumplex approved these changes

@Trial97 Trial97 Trial97 approved these changes

@getchoo getchoo getchoo approved these changes

Assignees
No one assigned
Labels
changelog:added A PR that appears under "Added" in the changelog manual backport PRs that have been backported manually
Projects
None yet
Milestone
8.1
Development

Successfully merging this pull request may close these issues.

Could not initialize class com.mojang.blaze3d.systems.RenderSystem starting from 1.19
4 participants
@bit69tream @Scrumplex @Trial97 @getchoo