[macOS] Fix instance update dialog #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Trial97
added
bug
|
haven't tested this yet but
note that the way QMessageBox is displayed was changed in Qt 6.5 to use the system dialog, so it's probably related to that |
DioEgizio
approved these changes
Jan 18, 2024
|
Tested it and it works |
Trial97
removed
the
needs-testing
|
Successfully created backport PR for |
Scrumplex
changed the title
Scrumplex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hopefully fixes #1910(partially)
I hope I fixed the button texts by replacing the deprecated function (
setButtonText).I could not find anywhere why the dialogs look so different between distros(but I suspect it is a mac thing), so I resolved myself by just updating the buttons' text.
This needs to be tested on mac.