[Linux] Fix opening files in external apps

[Scrumplex]

Closes #1490

How to test

1. Open a folder path
2. Ensure file manager opens
3. Open a file (edit a component in an instance)
4. Ensure that a text editor opens

[Trial97]

Please consider removing IndirectOpen and isSandbox as they are not used anywhere with your current changes.
The code looks good. This still needs testing as I was never able to reproduce the actual issue.

[TheKodeToad]

Why the removal of IndirectOpen? What reason did it exist for - did it fix anything - and will removing it make more bugs present? Or was there something which stopped it working properly which can be changed?

[Scrumplex]

Why the removal of IndirectOpen? What reason did it exist for - did it fix anything - and will removing it make more bugs present? Or was there something which stopped it working properly which can be changed?

I am not quite sure myself. But I wouldn't be surprised if MultiMC's issues stemmed from its ancient Qt version.

[develcooking]

Just in advance:
I'm not involved in the Prism Launcher, Multi MC or any of that. I also didn't read most of the code. I just want to open my folder from Prism. So I'm trying by searching and gifting possible answers for @TheKodeToad 's questions

What reason did it exist for - did it fix anything?

• After searching through the commit history of DesktopServices.cpp I found this out

• This is the first commit that added the DesktopService.cpp file wrap QDesktopServices and QProcess::startDetached which I think fixed LD_LIBRARY_PATH set for MultiMC leaks to other processes the Qt-9328 bug

• Other commits in the file:

• there also a lot changed
  all other

• here was an update to support FreeBSD

• all other commits just moved the file around but didn't changed it

• The commit history of the DesktopService.cpp file : link to commit history of Multi MC

did it fix anything?

Yes think so. It fixed the self reported bug at issue 1389 LD_LIBRARY_PATH set for MultiMC leaks to other processes](MultiMC/Launcher#1389)

and will removing it make more bugs present? Or was there something which stopped it working properly which can be changed?

I didn't find any while testing it see last uploaded video at issue #1490

On my end @Scrumplex branch works

I hope this could help at leased a little bit

[TheKodeToad]

Sorry! I probably could have figured this out if I put in more effort. I assumed Scrumplex knew though.

[TheKodeToad]

I am pretty sure this will reintroduce the bugs which the IndirectOpen impl was meant to fix :/

[Scrumplex]

I am pretty sure this will reintroduce the bugs which the IndirectOpen impl was meant to fix :/

But no other Qt app I know uses IndirectOpen or something similar. This really seems like a legacy workaround that is not relevant nowadays

[TheKodeToad]

I will approve if you fix the thing I mentioned - or you do not see it to be necessary!

[Scrumplex]

I will approve if you fix the thing I mentioned - or you do not see it to be necessary!

I was working on it ^^

[shellheim]

I will approve if you fix the thing I mentioned - or you do not see it to be necessary!

It still doesn't work in flatpak though :(

[Scrumplex]

It still doesn't work in flatpak though :(

Do you have any other Qt (5) apps in Flatpak to compare?

[shellheim]

There are many qt5 apps which can open files but I don't have any that needs to open folders.

[Trial97]

Maybe related to: #993

[github-actions]

Successfully created backport PR for release-8.x:

• [Backport release-8.x] Open paths directly #2035