Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log Microsoft refresh tokens #1964

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

Scrumplex
Copy link
Member

This prevents logging refresh tokens

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex Scrumplex changed the title fix: don't log katabasis by default Don't log Microsoft refresh tokens Dec 17, 2023
@Scrumplex Scrumplex added this to the 8.1 milestone Dec 17, 2023
@Scrumplex Scrumplex added bug Something isn't working simple change changelog:fixed A PR that appears under "Fixed" in the changelog backport release-8.x Backport PR automatically labels Dec 17, 2023
Copy link
Member

@TayouVR TayouVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what the heck is katabasis?
I can only find some greek mythology thing... https://en.wikipedia.org/wiki/Katabasis
and this XNA fork https://github.com/bottlenoselabs/katabasis

@Trial97
Copy link
Member

Trial97 commented Dec 17, 2023

what the heck is katabasis?

Is the name of the library responsible for the OAuth(https://github.com/PrismLauncher/PrismLauncher/tree/develop/libraries/katabasis)

@TayouVR
Copy link
Member

TayouVR commented Dec 17, 2023

what the heck is katabasis?

Is the name of the library responsible for the OAuth(develop/libraries/katabasis)

ah thank you xD

@TheKodeToad TheKodeToad merged commit e39a034 into PrismLauncher:develop Dec 19, 2023
35 checks passed
Copy link
Contributor

Successfully created backport PR for release-8.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-8.x Backport PR automatically bug Something isn't working changelog:fixed A PR that appears under "Fixed" in the changelog simple change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants