Mod downloader page improvements #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lumiscosity <averyrudelphe@gmail.com>
Mirrors Modrinth page behaviour. Signed-off-by: lumiscosity <averyrudelphe@gmail.com>
Trial97
reviewed
Dec 23, 2023
Signed-off-by: lumiscosity <averyrudelphe@gmail.com>
Trial97
approved these changes
Dec 23, 2023
TheKodeToad
approved these changes
Dec 23, 2023
|
Please run clang format on your code(or fix the styling manually) |
Signed-off-by: lumiscosity <averyrudelphe@gmail.com>
|
styling should be fine now |
Trial97
added
bug
|
Successfully created backport PR for |
Scrumplex
added
changelog:changed
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-8.x
git worktree add -d .worktree/backport-1979-to-release-8.x origin/release-8.x
cd .worktree/backport-1979-to-release-8.x
git switch --create backport-1979-to-release-8.x
git cherry-pick -x 358cf5b3485cfb23cce226c02fef03523468d4eb 1bf386603dece42df0815495ae6b43b0e2d665c8 1e48bf838db3f72fd391ecf9c91aa8e693daf213 c29af83dc328612d340c54e3ec037b1264d66d51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1465
Fixes #1864
Signed-off-by: lumiscosity averyrudelphe@gmail.com