Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded legacy game parameters #1983

Merged
merged 1 commit into from Jan 5, 2024
Merged

Remove hardcoded legacy game parameters #1983

merged 1 commit into from Jan 5, 2024

Conversation

tildejustin
Copy link
Contributor

@tildejustin
remove legacy processArguments code
eca5d88 
Signed-off-by: tildejustin <spacepepper3.14@gmail.com>
TayouVR
TayouVR approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@TayouVR TayouVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going by the talk on discord this should work

@Trial97 Trial97 added simple change changelog:changed A PR that appears under "Changed" in the changelog legacy minecraft Issues and PRs relating to legacy versions of Minecraft labels Jan 3, 2024
@TheKodeToad TheKodeToad added the backport release-8.x Backport PR automatically label Jan 5, 2024
@TheKodeToad TheKodeToad added this to the 8.1 milestone Jan 5, 2024
@TheKodeToad TheKodeToad merged commit d56d21f into PrismLauncher:develop Jan 5, 2024
35 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Successfully created backport PR for release-8.x:

@github-actions github-actions bot mentioned this pull request Jan 5, 2024
Merged
@Scrumplex Scrumplex changed the title remove legacy processArguments code Remove hardcoded legacy game parameters Mar 3, 2024
@Scrumplex Scrumplex added changelog:removed A PR that appears under "Removed" in the changelog and removed changelog:changed A PR that appears under "Changed" in the changelog labels Mar 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 3, 2024

Backport failed for release-8.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-8.x
git worktree add -d .worktree/backport-1983-to-release-8.x origin/release-8.x
cd .worktree/backport-1983-to-release-8.x
git switch --create backport-1983-to-release-8.x
git cherry-pick -x eca5d88576900d32edea2000258f37d700af5f06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TayouVR TayouVR TayouVR approved these changes

@Trial97 Trial97 Trial97 approved these changes

@TheKodeToad TheKodeToad TheKodeToad approved these changes

Assignees
No one assigned
Labels
backport release-8.x Backport PR automatically changelog:removed A PR that appears under "Removed" in the changelog legacy minecraft Issues and PRs relating to legacy versions of Minecraft simple change
Projects
None yet
Milestone
8.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tildejustin @TayouVR @Trial97 @TheKodeToad @Scrumplex