Fix online mode in legacy versions #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
TheKodeToad
added
backport release-8.x
Trial97
approved these changes
Jan 2, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
libraries/launcher/legacy/org/prismlauncher/legacy/fix/online/OnlineModeFix.java
Fixed
Show fixed
Hide fixed
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
|
Try joining betacraft.uk with this enabled to test! |
Scrumplex
approved these changes
Jan 3, 2024
|
Successfully created backport PR for |
Merged
Scrumplex
changed the title
Scrumplex
added
the
changelog:fixed
Scrumplex
changed the title
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-8.x
git worktree add -d .worktree/backport-1999-to-release-8.x origin/release-8.x
cd .worktree/backport-1999-to-release-8.x
git switch --create backport-1999-to-release-8.x
git cherry-pick -x 05e453309629d2c4cc1cf4b1322669cb8aed21ff 345cdf5c9d6417b5c2ce15e8967de3886d1113f1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this commit lying around for a while