[macOS] Add code signing and notarization #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Scrumplex
added
macOS
Scrumplex
force-pushed
the
feat/macos-signing
branch
from
4025cd2
to
aea5167
Compare
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Scrumplex
force-pushed
the
feat/macos-signing
branch
from
abf29ea
to
5d0017b
Compare
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Scrumplex
force-pushed
the
feat/macos-signing
branch
from
5d0017b
to
de92327
Compare
|
Perhaps it is also time to split up our builds into separate workflows |
Trial97
approved these changes
Jan 17, 2024
|
Will the change from tar.gz to zip impact in any way the mac updater? |
It should work fine with the PR I linked above |
DioEgizio
approved these changes
Jan 18, 2024
Scrumplex
added
the
changelog:added
|
Git push to origin failed for release-8.x with exitcode 1 |
1 similar comment
|
Git push to origin failed for release-8.x with exitcode 1 |
Scrumplex
added a commit
that referenced
this pull request
Jan 18, 2024
Scrumplex
added
manual backport
|
Finally! 🤤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #141
TODO
.zipreleases (See Allow specifying file extensions for macOS artifacts prismlauncher.org#396)