Fix a few use-after-free bugs #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Exception(const QString& message) : std::exception(), m_message(message) { qCritical() << "Exception:" << message; } | ||
| Exception(const Exception& other) : std::exception(), m_message(other.cause()) {} | ||
| Exception(const QString& message) : std::exception(), m_message(message.toUtf8()) { qCritical() << "Exception:" << message; } | ||
| Exception(const Exception& other) : std::exception(), m_message(other.m_message) {} |
Check warning
Code scanning / CodeQL
Inconsistent definition of copy constructor and assignment ('Rule of Two') Warning
Trial97
approved these changes
Feb 12, 2024
Scrumplex
reviewed
Feb 12, 2024
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
Scrumplex
approved these changes
Feb 13, 2024
|
Git push to origin failed for release-8.x with exitcode 1 |
|
Successfully created backport PR for |
Scrumplex
added
the
changelog:fixed
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-8.x
git worktree add -d .worktree/backport-2116-to-release-8.x origin/release-8.x
cd .worktree/backport-2116-to-release-8.x
git switch --create backport-2116-to-release-8.x
git cherry-pick -x ded77e61832661557a6985d9aa587f3b5d1e1f87 ff989b4305d5ae4578d2154afe27ce6bf72cadaf 7f4c74ffbe413fcf191842606c12056fbc6493c7 8cf2a04f317c59920e8af90d7e16fea872b2c122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.