Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve empty instance list label #2141

Merged
merged 1 commit into from Feb 22, 2024

Conversation

crpz1
Copy link
Contributor

@crpz1 crpz1 commented Feb 19, 2024

This PR updates the welcome text label on an empty instance page to use the same code that other empty lists use within the launcher.

Signed-off-by: crpz1 <8588315+crpz1@users.noreply.github.com>
Copy link
Member

@Trial97 Trial97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have a eye for this kind of thing but it looks ok

Copy link
Member

@DioEgizio DioEgizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is def a lot better. thanks

@DioEgizio DioEgizio added this to the 8.1 milestone Feb 21, 2024
@DioEgizio DioEgizio added simple change ui rework changelog:changed A PR that appears under "Changed" in the changelog backport release-8.x Backport PR automatically labels Feb 21, 2024
@Scrumplex Scrumplex merged commit 1cdb9bd into PrismLauncher:develop Feb 22, 2024
35 checks passed
@Scrumplex Scrumplex changed the title Use empty list label code for welcome screen Improve empty instance list label Feb 22, 2024
Copy link
Contributor

Successfully created backport PR for release-8.x:

LunaisLazier pushed a commit to LunaisLazier/ShatteredPrism that referenced this pull request Feb 24, 2024
LunaisLazier added a commit to LunaisLazier/ShatteredPrism that referenced this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-8.x Backport PR automatically changelog:changed A PR that appears under "Changed" in the changelog simple change ui rework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants