Replace invalid characters when extracting ZIP #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
TheKodeToad
force-pushed
the
invalid-zip-files
branch
from
9499f01
to
8056a2f
Compare
timoreo22
added
backport release-8.x
Trial97
approved these changes
Apr 6, 2024
timoreo22
approved these changes
Apr 6, 2024
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mimics CurseForge app's behaviour
Fixes #564
(The pack in that issue was actually had bad filename encoding so the pack will have
-instead of §, unfortunately i don't think there's a way around this)Maybe Linux also needs characters replacing? Is it possible for a zip filename to contain a null byte?