Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for launching from command line in offline mode #2331

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Support for launching from command line in offline mode #2331

wants to merge 4 commits into from

Commits on Apr 23, 2024

  1. Support for launching from command line in offline mode 

    This allows launching an offline instance with --offline --name=OfflineName. This is useful for playing split screen by creating two side-by-side instances, which is impossible online, unless one is using two separate paid accounts.

With this PR, it makes it possible to launch from a script - otherwise, one has to launch manually, which is a pain, or create offline profiles for each instance, which interferes with some functionality like skins (my autistic son takes great issue with his skin not being visible, when using offline profiles!).

Implementation is based on MultiMC, which supports this feature.

See also PrismLauncher#1059 for discussion.

Signed-off-by: Michael Tyson <michael@atastypixel.com>
    @michaeltyson
    michaeltyson committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    835cc29 View commit details
    Browse the repository at this point in the history

  2. Improved formatting, fixed mistakenly-added local variable 

    Signed-off-by: Michael Tyson <michael@atastypixel.com>
    @michaeltyson
    michaeltyson committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    7e8ae91 View commit details
    Browse the repository at this point in the history

  3. Small format change in launcher/LaunchController.h to appease the che… 

    …cker

Co-authored-by: Alexandru Ionut Tripon <alexandru.tripon97@gmail.com>
Signed-off-by: Michael Tyson <michael@atastypixel.com>
    @michaeltyson @Trial97
    michaeltyson and Trial97 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    7bd88df View commit details
    Browse the repository at this point in the history

  4. Removed “--name” flag in favour of specifying offline player name via… 

    … “--offline” flag

Signed-off-by: Michael Tyson <michael@atastypixel.com>
    @michaeltyson
    michaeltyson committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    7e91e7e View commit details
    Browse the repository at this point in the history