add theme selection to setup wizard

[TayouVR]

This moves the UI code for selecting theme, icon theme and background cat from LauncherPage to ThemeCustomizationWidget, which is then embedded in both LauncherPage and ThemeSetupWizard.

TODO:

• Add Wizard Page for Theming
• use common code for LauncherPage and Wizard Page
• change Theme immediately upon choosing different item
• clean up UI code (if/else if/else & switch/case -> [i]/get/set/indexOf) https://github.com/PrismLauncher/PrismLauncher/pull/249/files#diff-c115806ef59a43f5ab5ca792b1f5f861612946f391a076e07928c4ed1bd1a447L289 -> https://github.com/PrismLauncher/PrismLauncher/pull/249/files#diff-ee2722496429e9dee7a6ef8fd601be31996920cf7ef55ba3ec6ec8ac90bef2b6R54ee2722496429e9dee7a6ef8fd601be31996920cf7ef55ba3ec6ec8ac90bef2b6R102

X currently only displaying some of the widgets doesn't layout perfectly, this doesn't break functionality, but if someone has a way to fix it, I'd greatly appreciate. (related code: https://github.com/PrismLauncher/PrismLauncher/pull/249/files#diff-ee2722496429e9dee7a6ef8fd601be31996920cf7ef55ba3ec6ec8ac90bef2b6R63)

Blocked by #510 Resolved in #600

[TayouVR]

oof, my jank connect() fails on Qt5... honestly not all that surprising... was planning to rework that part anyways x3

[TayouVR]

ready for review, finally x3

[flowln]

this is very cool, i love the demo thingies on the setup wizard 😍

the theme ignoring issue however is very critical, my dark theme doesn't get applied when i open up the launcher 😭

[Scrumplex]

LGTM! Thanks a lot

[HyperSoop]

Why would all new users need to customize their cat though? seems like a weird thing to preview and emphasis a literal easter egg.

[DioEgizio]

Why would all new users need to customize their cat though? seems like a weird thing to preview and emphasis a literal easter egg.

why not? it's not really an easter egg at this point either

[HyperSoop]

Why would all new users need to customize their cat though? seems like a weird thing to preview and emphasis a literal easter egg.

why not? it's not really an easter egg at this point either

It seems like something normal on the inside of this community but someone coming to use the software from the outside would see this as very very weird and unfitting.

[DioEgizio]

Conflicting with develop

[TayouVR]

Why would all new users need to customize their cat though? seems like a weird thing to preview and emphasis a literal easter egg.

I couldn't get the cat dropdown to disappear without leaving a gap, so I decided to just let ppl choose the cat too..

[HyperSoop]

this is seriously unacceptable though. the cat should definitely not be featured in the setup wizard. this is not competent software design and should never be resorted to

[TayouVR]

uhh, I don't like githubs feature to do this here, will redo that resolving conflicts locally and push in a second

[TayouVR]

@HyperSoop the cat being there doesn't hurt anyone and sure, I wouldn't have put it there, but you are free to remove it in a separate PR if you want. The function in question is this one: https://github.com/PrismLauncher/PrismLauncher/pull/249/files#diff-ee2722496429e9dee7a6ef8fd601be31996920cf7ef55ba3ec6ec8ac90bef2b6R64 (ThemeCustomizationWidget::showFeatures) read the comment above function to see what i had already tried without luck

[HyperSoop]

I'm no programmer, i'm just giving my feedback. I cannot work on this, but this is clearly unacceptable to merge as is.

[HyperSoop]

I'm not overexaggerating. Imagine being a new user and being told "hey, you really gotta choose the cat picture you want!" This is beyond stupid. This is not much by itself, but can snowball into more such horrible design choices accepted from PRs.

In fact, incompetent/incomplete/badly designed PRs have already been accepted, as an example take the old modpack updater.

[DioEgizio]

It's not an horrible design choice? And if the cat wasn't there, the space would probably just not be used

[TayouVR]

yeah, the page is otherwise empty anyways...

[HyperSoop]

You don't say "we need to use the space somehow" and add a meme atop your entire UI. this is literally it - plastering a huge meme onto it.

[DioEgizio]

The cat isn't a meme though

[HyperSoop]

It is an inside joke, this changes nothing. Still weird and unfitting.

[flowln]

I'm not overexaggerating. Imagine being a new user and being told "hey, you really gotta choose the cat picture you want!" This is beyond stupid. This is not much by itself, but can snowball into more such horrible design choices accepted from PRs.

In fact, incompetent/incomplete/badly designed PRs have already been accepted, as an example take the old modpack updater.

You are saying a page on a wizard someone sees once in the entire time they use the launcher is badly designed because we're using the extra space that would otherwise be empty to show a customization option in the customization page. Look at yourself.

And how about you stop saying shit about other people's free work? Time and time again you come here to shit on this project's choices without understanding a single thing about what is being done and why. You're being the incompetent here.

[TayouVR]

the cat is not a meme or joke. It has been part of MultiMC for like a decade. Exposing the option to set the cat here is fine. As I said before I didn't intend to originally, but theres nothing wrong with selecting it in the wizard.

[TayouVR]

on another note, here are some ugly hints...

[HyperSoop]

You are saying a page on a wizard someone sees once in the entire time they use the launcher is badly designed because we're using the extra space that would otherwise be empty to show a customization option in the customization page. Look at yourself.

And how about you stop saying shit about other people's free work? Time and time again you come here to shit on this project's choices without understanding a single thing about what is being done and why. You're being the incompetent here.

Respecting other people's free work is no excuse to add bad changes conflicting with the going design philosophy and harming the UX.

The cat is not a highlightable feature of the launcher, not a feature that would sell it to people, and not one that you should recommend to new users right off. Look at yourself, exit the echo chamber you're in, and look at how stupid the whole situation is.

[TayouVR]

You are being extremely disrespectful and hurtful. As I originally said I agree, and didn't want to add the cat there myself either, but you did not provide constructive criticism, but instead harass and insult contributors for their free work & time. I will stop responding to you now, this is not worth my time.

[flowln]

Respecting other people's free work is no excuse to add bad changes conflicting with the going design philosophy and harming the UX.

The cat is not a highlightable feature of the launcher, not a feature that would sell it to people, and not one that you should recommend to new users right off. Look at yourself, exit the echo chamber you're in, and look at how stupid the whole situation is.

Respecting other people's free work means not bullshitting on people's work because the feature that works but could have improvements is an "incompetent/incomplete/badly designed PR" as you so like to say. And even more, a feature that only got released like it was because the whole project almost exploded because of other stuff. And even then, it's a one dialog thing that you can simply ignore, and you keep talking about it like it was hell on earth. Come on.

The cat is important enough that a sizeable amount of the community likes it and uses it. No one cares whether the launcher has a cat or not, besides you it seems. If they don't like the cat, they can just move on with their life without the cat. And yet you keep talking about it as if adding it to the customization wizard was a mortal sin. Maybe you should look at how stupid the whole situation is.

[flowln]

seems to work fine for me, thank you!