Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old updater code #458

Merged
merged 3 commits into from Jan 25, 2023
Merged

Remove old updater code #458

merged 3 commits into from Jan 25, 2023

Conversation

Scrumplex
Copy link
Member

No description provided.

@flowln flowln added the enhancement New feature or request label Nov 16, 2022
@flowln flowln added this to the 6.0 milestone Nov 16, 2022
@Scrumplex Scrumplex force-pushed the remove-updater branch 2 times, most recently from cc746db to b37762c Compare November 16, 2022 17:25
@Scrumplex Scrumplex marked this pull request as ready for review November 18, 2022 17:23
@Scrumplex
Copy link
Member Author

I don't know if this works on macOS 👀

@flowln flowln self-requested a review November 20, 2022 12:23
flowln
flowln approved these changes Nov 20, 2022
View reviewed changes
Copy link
Contributor

@flowln flowln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

you should probably make some way of testing if it works (maybe a release on your branch, and make a temporary branch based on this with a different URL for the updater?) on macOS, and ping the test subjects for it :>

@DioEgizio
Copy link
Member

I don't know if this works on macOS 👀

works fine, even tried updating and everything worked

@Scrumplex
refactor: remove old updater
fdbd8d9 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex Scrumplex modified the milestones: 6.0, 7.0 Nov 27, 2022
@Scrumplex
Copy link
Member Author

Moving this to 7.0 as it's fairly unimportant

@HyperSoop
Copy link
Contributor

Why is this unimportant? the old updater code needs to be exterminated asap it's one of the most annyoing things i've ever seen in my life

@Scrumplex
Merge branch 'develop' into remove-updater
6e841a3 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex Scrumplex merged commit 0546345 into PrismLauncher:develop Jan 25, 2023
@Scrumplex Scrumplex deleted the remove-updater branch January 25, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flowln flowln flowln approved these changes

@timoreo22 timoreo22 timoreo22 approved these changes

@OEMunlag OEMunlag OEMunlag approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Scrumplex @DioEgizio @HyperSoop @flowln @timoreo22 @OEMunlag