Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import config from polymc.cfg if available #55

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Import config from polymc.cfg if available #55

merged 2 commits into from
Oct 18, 2022

Conversation

flowln
Copy link
Contributor

@flowln flowln commented Oct 18, 2022

This eases the migration when using the same data path :)

@flowln flowln added this to the 5.0 milestone Oct 18, 2022
@Scrumplex
Copy link
Member

Oh

@DioEgizio
Copy link
Member

failing on qt5

@flowln
feat: allow specifying fallbacks to INI files
801e7da 
Signed-off-by: flow <flowlnlnln@gmail.com>
@flowln
fix: add fallback for polymc.cfg
32cdfb8 
Signed-off-by: flow <flowlnlnln@gmail.com>
pog5
pog5 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@pog5 pog5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flowln flowln added the enhancement New feature or request label Oct 18, 2022
@DioEgizio DioEgizio merged commit fb4cf0b into PrismLauncher:develop Oct 18, 2022
@flowln flowln deleted the config_add_fallback branch October 18, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scrumplex Scrumplex Scrumplex approved these changes

@pog5 pog5 pog5 approved these changes

@DioEgizio DioEgizio DioEgizio approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flowln @Scrumplex @DioEgizio @pog5