New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safer destructive actions #618
Safer destructive actions #618
Conversation
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution :)
i agree a utility for the confirmation dialogs would be useful here, perhaps somewhere in CustomMessageBox
or GuiUtil
, possibly with different functions for single item and multiple item confirmations. doesn't necessarily need to be in this PR though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks fine to me, thanks!
please add a signoff in f7c5eb1
or make a remediation commit :)
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
a226cb0
to
cbe5af2
Compare
I've removed them via rebase. |
You're is used in some other places but im lazy Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
Thanks! |
Fixes #298
Fixes PolyMC/PolyMC#948. Well, it obviously won't actually close the issue. I went further though - some may say it's too hard to do dumb things now.
Unfortunately it still says "may be permanent" which in my opinion is not really great. Perhaps it could be adapted to whether Flatpak is being used, and perhaps the whole dialog logic could be moved into a utility since it's now used a lot.