Remove commit hash from builds where git wasn't installed at build time #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: seth <getchoo@tuta.io>
flowln
approved these changes
Dec 23, 2022
flowln
added
bug
Scrumplex
approved these changes
Dec 23, 2022
Signed-off-by: seth <getchoo@tuta.io>
|
pr has the scare number 😱 |
Scrumplex
changed the title
Scrumplex
pushed a commit
that referenced
this pull request
Feb 2, 2023
scrump heard your pleads, rejoice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since builds are already assumed to be stable when outside of a git repo, i think it would be okay to assume their stable when
and maybe some others out there as well) and not force
gitisn't found either. this would fix issues with current packages that build from the vendor tarball displaying the commit hash in the title bar (minegitto be a build dependency when it really isn't needed outside of this.Signed-off-by: seth getchoo@tuta.io