Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1.16+ Forge Technic Launcher imports #710

Merged
merged 1 commit into from Jan 7, 2023
Merged

Fix 1.16+ Forge Technic Launcher imports #710

merged 1 commit into from Jan 7, 2023

Conversation

byquanton
Copy link
Contributor

@byquanton byquanton commented Jan 5, 2023 •
edited

Fixes #708

@byquanton
fix: Add 1.16+ Forge library prefix in TechnicPackProcessor.cpp
2faf833 
Signed-off-by: byquanton <32410361+byquanton@users.noreply.github.com>
@byquanton byquanton changed the title [DRAFT] Fix newer Forge Versions Import for Technic Modpacks Fix 1.16+ Forge Technic Launcher imports Jan 6, 2023
@byquanton byquanton marked this pull request as ready for review January 6, 2023 01:45
@DioEgizio DioEgizio added bug Something isn't working simple change labels Jan 6, 2023
@DioEgizio DioEgizio modified the milestone: 6.2 Jan 6, 2023
flowln
flowln approved these changes Jan 7, 2023
View reviewed changes
Copy link
Contributor

@flowln flowln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@DioEgizio DioEgizio added this to the 6.2 milestone Jan 7, 2023
@Scrumplex Scrumplex merged commit 9901ecd into PrismLauncher:develop Jan 7, 2023
Scrumplex added a commit that referenced this pull request Feb 2, 2023
@Scrumplex
Merge pull request #710 from byquanton/develop
3fc63fa 
Fixes #708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flowln flowln flowln approved these changes

@Scrumplex Scrumplex Scrumplex approved these changes

@SalmonSays SalmonSays SalmonSays approved these changes

@DioEgizio DioEgizio DioEgizio approved these changes

@FlexionConnexion FlexionConnexion FlexionConnexion approved these changes

Assignees
No one assigned
Labels
bug Something isn't working simple change
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.

Forge Technic Packs Past ~1.16.5 Appear Broken
6 participants
@byquanton @flowln @Scrumplex @SalmonSays @DioEgizio @FlexionConnexion