Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add teawie as a cat #715

Merged
merged 6 commits into from Jan 9, 2023
Merged

add teawie as a cat #715

merged 6 commits into from Jan 9, 2023

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Jan 7, 2023

drawn by @SympathyTea

image
image

Signed-off-by: seth getchoo@tuta.io

drawn by sympathytea (https://github.com/SympathyTea)

Signed-off-by: seth <getchoo@tuta.io>
@HurricanePootis
Copy link

I LOVE THIS!!!!!!!!!!!!!! (i will blow up teawie)

@getchoo getchoo changed the title add teawie add teawie as cat Jan 7, 2023
@getchoo getchoo changed the title add teawie as cat add teawie as a cat Jan 7, 2023
@SympathyTea
Copy link

this is everything i could ever want out of a launcher, tbh
so proud my dinky little meme drawing is getting this far

@AshtakaOOf
Copy link
Contributor

Wait Teawie is a cat? Wth!

@getchoo
Copy link
Member Author

getchoo commented Jan 7, 2023

Wait Teawie is a cat? Wth!

yes, totally :sus:

@AshtakaOOf
Copy link
Contributor

AshtakaOOf commented Jan 7, 2023

Change the cat option to "pet" then, but tbh it's too vibrant.

@SympathyTea
Copy link

Change the cat option to "pet" then, but tbh it's too vibrant.

too vibrant?
elaborate pls

@getchoo
Copy link
Member Author

getchoo commented Jan 7, 2023

i was thinking of changing it to "background," but pet is also a good choice

but tbh it's too vibrant

how so? i know the blue and pink on the head are bright, but i wouldn't say it's overwhelming in any way. parts of rory are also fairly vibrant and i mean...the original multimc cat is literally all white. i don't see how this is much of an issue

@AshtakaOOf
Copy link
Contributor

Doesn't fit the launcher at all, but that's my opinion.
My opinion is mostly trash anyway.

@sakecode
Copy link

sakecode commented Jan 7, 2023

good PR

@getchoo
Copy link
Member Author

getchoo commented Jan 7, 2023

Doesn't fit the launcher at all, but that's my opinion.

are they supposed to? do the other cats? the original multimc cat doesn't fit in with the new flat icons being used, and rory looks a lot more realistic and has colors not found anywhere else in the launcher. i would understand thinking a different pose might be better or that it should be scaled differently, but saying it doesn't fit in the launcher at all is a bit of stretch for what's the equivalent of a fun easter egg imo

@AshtakaOOf
Copy link
Contributor

It's my opinion

@sakecode
Copy link

sakecode commented Jan 7, 2023

I agree with Getchoo they're more like Easter Eggs not suppose to fit in but be a fun reference to something.

@getchoo
Copy link
Member Author

getchoo commented Jan 7, 2023

It's my opinion

i know, i'm just trying to understand where you're coming from to see what changes should be made (if any) so it can be better

@AshtakaOOf
Copy link
Contributor

Well first downscale the png to be less overwhelming...

@SympathyTea
Copy link

Well first downscale the png to be less overwhelming...

both rory versions and the multimc cat are pretty large
tbh i dont see your point

@AshtakaOOf
Copy link
Contributor

But yeah actually don't listen to me I'm just sleepy.
Goodnight :)

@HurricanePootis
Copy link

I LOVE THIS (i will no longer try to blow up teawie 😭)

@hisashiburii
Copy link

I LOVE TEAWIE (i make teawie memes sometimes)

Signed-off-by: seth <getchoo@tuta.io>
Signed-off-by: seth <getchoo@tuta.io>
gimp fail

Signed-off-by: seth <getchoo@tuta.io>
Signed-off-by: seth <getchoo@tuta.io>
@getchoo
Copy link
Member Author

getchoo commented Jan 7, 2023

here are the event variants

christmas:
teawie-xmas

birthday:
teawie-bday

halloween:
teawie-spooky

@TheKodeToad
Copy link
Member

Whoa... that's a lot of emails I've had today! Thanks GitHub.

Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. What's the license for these files though? Maybe add a comment about the license to the resources file

@flowln flowln added the enhancement New feature or request label Jan 7, 2023
@flowln flowln added this to the 7.0 milestone Jan 7, 2023
@UnlimitedCookies
Copy link

The question could become what background images should get bundled with the binary and which shouldn't. If all artwork files requested for inclusion by a PR get accepted, then this might become an icon pack instead of an MC launcher.

@TheKodeToad
Copy link
Member

TheKodeToad commented Jan 7, 2023

The question could become what background images should get bundled with the binary and which shouldn't. If all artwork files requested for inclusion by a PR get accepted, then this might become an icon pack instead of an MC launcher.

Are you trying to suggest that's a bad thing?! We're all here for the cat(s).

@flowln
Copy link
Contributor

flowln commented Jan 7, 2023

The question could become what background images should get bundled with the binary and which shouldn't. If all artwork files requested for inclusion by a PR get accepted, then this might become an icon pack instead of an MC launcher.

Eventually all background images should be removed from the binary, and dynamically loaded from a folder instead like what we do with themes currently, imo. But we don't yet have that logic, so for now we add the "cats" that a reasonable amount of people want in the launcher.

@SympathyTea
Copy link

SympathyTea commented Jan 7, 2023

What's the license for these files though?
Teawie is under the CC BY-SA license, feel free to use him for this particular background "cat"

https://commons.wikimedia.org/wiki/File:Teawie.png
https://commons.wikimedia.org/wiki/File:Teawie_Party.png
https://commons.wikimedia.org/wiki/File:Teawie_Holiday.png
https://commons.wikimedia.org/wiki/File:Teawie_Halloween.png

@AshtakaOOf
Copy link
Contributor

AshtakaOOf commented Jan 7, 2023

Teawie is a mouse? Or a cat from now on?

Signed-off-by: seth <getchoo@tuta.io>
@getchoo
Copy link
Member Author

getchoo commented Jan 8, 2023

Maybe add a comment about the license to the resources file

all of the attribution terms have been added there :)
let me know if i missed anything

@Scrumplex Scrumplex merged commit ca9b252 into PrismLauncher:develop Jan 9, 2023
@Scrumplex
Copy link
Member

🎉

@getchoo getchoo deleted the add-teawie branch April 10, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet