ui: Let Qt 6.4.2 handle dark mode titlebar #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TheLastRar <TheLastRar@users.noreply.github.com>
TayouVR
approved these changes
Jan 9, 2023
DioEgizio
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt 6.4 will automatically set the title bar to dark mode on Windows when using a dark theme, but prior to Qt 6.4.2 it only set the title bar dark mode on window open, and wouldn't update already open windows on theme change.
Qt 6.4.2 fixes that, updating the title bar dark mode on all open windows on theme change.
The legacy build does lose dark mode title bar support, but that feature is only present on 10+ anyway.
Addresses the suggestion made in #352 (comment)
Closes #158