Fix random ResourceFolderModel test failures on some Windows builds #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason this makes some of our CI test runs super slow, and sometimes fail miserably. Signed-off-by: flow <flowlnlnln@gmail.com>
flowln
added
bug
|
I had also looked into this and found that the trash function was at fault, although I never figured out why Qt 5 was much more adversely affected over Qt 6. |
DioEgizio
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my
not so through and not very scientifictesting, it seems like trashing on Windows Server (used by the CI runner) is borked :)The tests started failing after the PR that added confirmation on deletion was added, and ever since, when the test didn't outright fail, it took seconds to complete, particularly on the MSVC Legacy builds. With this patch, it seems to be back to normal.
Anyway, we don't really need to trash the files on the tests for them to test what they do, so 🤷♀️