Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve MinGW ccache #803

Merged
merged 3 commits into from Feb 4, 2023
Merged

Conversation

TheLastRar
Copy link
Contributor

@TheLastRar TheLastRar commented Feb 1, 2023

Seeing if I can improve build times by adjusting the MinGW ccache setup

First two commits setup ccache stat logging to match the other CI builds

The last commit gives a unique name to the cache as per the https://github.com/actions/cache/blob/main/tips-and-workarounds.md#update-a-cache

Edit: I could split the ccache stat logging and the cache rename commits into separate PRs if preferred.

Signed-off-by: TheLastRar <TheLastRar@users.noreply.github.com>
Signed-off-by: TheLastRar <TheLastRar@users.noreply.github.com>
Also change name to avoid pulling the stale cache

Signed-off-by: TheLastRar <TheLastRar@users.noreply.github.com>
@flowln flowln added enhancement New feature or request actions Issues and PRs related to GH actions and other CIs we might have Windows Issues and PRs related to WIndows specifically labels Feb 1, 2023
@flowln flowln requested a review from DioEgizio February 2, 2023 21:48
Copy link
Contributor

@flowln flowln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@flowln flowln merged commit 74a875b into PrismLauncher:develop Feb 4, 2023
@Scrumplex Scrumplex added this to the 7.0 milestone Feb 4, 2023
@TheLastRar TheLastRar deleted the msys2-ccache branch February 4, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions Issues and PRs related to GH actions and other CIs we might have enhancement New feature or request Windows Issues and PRs related to WIndows specifically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants