Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java installations detection fix for Linux #823

Merged
merged 1 commit into from Feb 5, 2023

Conversation

BalkanMadman
Copy link
Contributor

@BalkanMadman BalkanMadman commented Feb 4, 2023

Fix #790
Now it is able to detect symbolic links and show their real paths. Tested on Gentoo GNU/Linux (my machine, of course)

Signed-off-by: BalkanMadman zurabid2016@gmail.com

Signed-off-by: BalkanMadman <zurabid2016@gmail.com>
@Scrumplex Scrumplex added bug Something isn't working simple change Linux Issues and PRs related to Linux specifically labels Feb 4, 2023
@Scrumplex Scrumplex added this to the 7.0 milestone Feb 4, 2023
Copy link
Contributor

@Ryex Ryex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead simple use of canonicalFilePath
looks good

Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Scrumplex Scrumplex merged commit e89a109 into PrismLauncher:develop Feb 5, 2023
@BalkanMadman BalkanMadman deleted the linux-java branch February 10, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Linux Issues and PRs related to Linux specifically simple change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweaking the java auto-detection for Linux
4 participants