Add Windows codesigning #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Scrumplex
added
actions
DioEgizio
approved these changes
Feb 16, 2023
DioEgizio
reviewed
Feb 16, 2023
|
Yeah the command is wrong there. Oops |
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Scrumplex
force-pushed
the
codesign-windows
branch
from
09b964e
to
33bf85a
Compare
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Was there an issue for this? Anyway. Our long awaited code signing certificate is here.
Seems to work as expected (No SmartScreen!)
You can grab a signed build from here for testing: https://github.com/Scrumplex/PrismLauncher/actions/runs/4187539874