Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch Subdirectories of Watched folders in Blocked Mods Dialog #946

Merged
merged 10 commits into from Apr 14, 2023

Conversation

Ryex
Copy link
Contributor

@Ryex Ryex commented Mar 21, 2023

What is says on the tin. Pretty simple addition

closes #938

Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
launcher/ui/dialogs/BlockedModsDialog.cpp Outdated Show resolved Hide resolved
launcher/ui/dialogs/BlockedModsDialog.cpp Outdated Show resolved Hide resolved
@Ryex
Copy link
Contributor Author

Ryex commented Mar 28, 2023

Recursive search on the downloads folder is now attached to a setting.

Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
launcher/ui/pages/global/LauncherPage.ui Outdated Show resolved Hide resolved
launcher/ui/pages/global/LauncherPage.ui Outdated Show resolved Hide resolved
launcher/ui/pages/global/LauncherPage.cpp Outdated Show resolved Hide resolved
launcher/ui/dialogs/BlockedModsDialog.cpp Outdated Show resolved Hide resolved
Ryex and others added 3 commits April 2, 2023 16:39
-expand columspan on new UI element
-improve tooltip

Co-authored-by: flow <flowlnlnln@gmail.com>
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
@flowln flowln added the enhancement New feature or request label Apr 7, 2023
@flowln flowln added this to the 7.0 milestone Apr 7, 2023
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works on my machine:tm:

launcher/ui/dialogs/BlockedModsDialog.h Outdated Show resolved Hide resolved
Copy link
Member

@DioEgizio DioEgizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on my machine

…fusion of behavior)

Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
@Scrumplex Scrumplex merged commit 1b05303 into PrismLauncher:develop Apr 14, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mod Download Folder not recursively searched.
4 participants