fix: divide minecraftpage into tabs #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this way small screen users can use the launcher settings without having window a bigger than their actual screens Signed-off-by: DioEgizio <83089242+DioEgizio@users.noreply.github.com>
|
Maybe it should be named "Workarounds" like the instance window? Ideally the group box should also be labelled "Native libraries" too. |
Mangohud/gamemode aren't workarounds though. I didn't find any better name :/ |
|
Maybe have it in a performance tab then. |
|
Native lib workarounds aren't necessarly performance, and making a tab for every group seems a bit weird so idk |
|
That is the situation in the instance window. |
flowln
approved these changes
Apr 7, 2023
Scrumplex
reviewed
May 5, 2023
Co-authored-by: Sefa Eyeoglu <contact@scrumplex.net> Signed-off-by: DioEgizio <83089242+DioEgizio@users.noreply.github.com>
Scrumplex
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this way small screen users can use the launcher setting without having window a bigger than their actual screens
closes partially #220
some screenshots
general tab
System-related tweaks tab (here there'd be the perfomance part on linux)
i tried to resize the new instance dialog but failed at it :/. Not too much of an issue as it's not as bad as what settings was