hold back CollectionView Adapter

PrismLibrary · Aug 20, 2020 · 09ecf4a · 09ecf4a
1 parent 3726ad1
commit 09ecf4a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/e2e/Forms/src/HelloWorld/Views/MyMasterDetail.xaml b/e2e/Forms/src/HelloWorld/Views/MyMasterDetail.xaml
@@ -46,9 +46,9 @@
               <Button Text="CarouselView Region"
                       Command="{Binding NavigateCommand}"
                       CommandParameter="MyNavigationPage/CarouselDemoRegion" />
-              <Button Text="CollectionView Region"
+              <!--<Button Text="CollectionView Region"
                       Command="{Binding NavigateCommand}"
-                      CommandParameter="MyNavigationPage/CollectionViewDemoRegion" />
+                      CommandParameter="MyNavigationPage/CollectionViewDemoRegion" />-->
               <Button Text="ContentView Region"
                       Command="{Binding NavigateCommand}"
                       CommandParameter="MyNavigationPage/ContentViewDemoRegion" />

diff --git a/src/Forms/Prism.Forms.Regions/Ioc/RegionRegistrationExtensions.cs b/src/Forms/Prism.Forms.Regions/Ioc/RegionRegistrationExtensions.cs
@@ -27,7 +27,9 @@ public static IContainerRegistry RegisterRegionServices(this IContainerRegistry
                 configureAdapters?.Invoke(regionAdapterMappings);
 
                 regionAdapterMappings.RegisterDefaultMapping<CarouselView, CarouselViewRegionAdapter>();
-                regionAdapterMappings.RegisterDefaultMapping<CollectionView, CollectionViewRegionAdapter>();
+                // TODO: CollectionView is buggy with only last View showing dispite multiple Active Views
+                // BUG: iOS Crash with CollectionView https://github.com/xamarin/Xamarin.Forms/issues/9970
+                //regionAdapterMappings.RegisterDefaultMapping<CollectionView, CollectionViewRegionAdapter>();
                 regionAdapterMappings.RegisterDefaultMapping<Layout<View>, LayoutViewRegionAdapter>();
                 regionAdapterMappings.RegisterDefaultMapping<ScrollView, ScrollViewRegionAdapter>();
                 regionAdapterMappings.RegisterDefaultMapping<ContentView, ContentViewRegionAdapter>();