Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XF Modularity Enhancements #1139

Closed
dansiegel opened this issue Aug 9, 2017 · 3 comments
Closed

XF Modularity Enhancements #1139

dansiegel opened this issue Aug 9, 2017 · 3 comments

Comments

@dansiegel
Copy link
Member

The following enhancements should be added to make Prism Modularity easier to work with:

  1. Extension Method to determine if a Module has been added
  2. Extension Method to determine if a Module has been initialized
  3. Extension Methods should be made to support support for evaluating the Module by type/name similar to the current generic extensions for AddModule
  4. The Module Catalog should use an ObservableCollection rather than a List to allow the automatic initialization of Modules added to the Module Catalog. Specifically when that Module is registered with InitializationMode.WhenAvailable, and AFTER IModuleManager.Run() has been called.
    1. This requirement would also mean that the Module Manager should be run even if no Modules were added to the Catalog as we would need to ensure that Modules could be added successfully later.
dansiegel added a commit to dansiegel/Prism that referenced this issue Aug 10, 2017
@brianlagunas
Copy link
Member

Option 4 is not a scenario that needs to be handled.

@dansiegel
Copy link
Member Author

Autofac Modules in Prism Forms should also be updated to support a more traditional Module approach

public interface IAutofacModule : IModule
{
    void Initialize(ContainerBuilder builder);
}

public abstract class AutofacModuleBase : IAutofacModule
{
    public void Initialize() => new NotImplementedException();

    public abstract void Initialize(ContainerBuilder builder);
}

This would allow Prism.Autofac.Forms to then provide it's own ModuleManager with the PrismApplication's ContainerBuilder so that it can pass the builder into the modules Initialize method before the Container is built.

@lock
Copy link

lock bot commented Jan 30, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants