Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SetNavigationServiceForPage protected #2288

Closed
dansiegel opened this issue Dec 23, 2020 · 0 comments · Fixed by #2323
Closed

Make SetNavigationServiceForPage protected #2288

dansiegel opened this issue Dec 23, 2020 · 0 comments · Fixed by #2323
Labels
enhancement XF

Comments

@dansiegel
Copy link
Member

Summary

As described in the Discussion #2247, CreatePage calls the private method SetNavigationServiceForPage which makes it harder to override. As a solution SetNavigationServiceForPage should be made protected.
@dansiegel dansiegel added this to the Prism 8.1 milestone Dec 23, 2020
dansiegel added a commit that referenced this issue Jan 28, 2021
@dansiegel
Fixes #2288 make SetNavigationServiceForPage protected
96aa296
@dansiegel dansiegel linked a pull request Jan 28, 2021 that will close this issue
Make SetNavigationServiceForPage protected #2323
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement XF
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make SetNavigationServiceForPage protected PrismLibrary/Prism
1 participant
@dansiegel