Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for ActiveAware NavPages in a TabbedPage #1164

Merged
merged 1 commit into from
Sep 20, 2017

Conversation

brianlagunas
Copy link
Member

@brianlagunas brianlagunas commented Sep 20, 2017

Fixes issue #1076.

Changes proposed in this pull request:

  • modified TabbedPageActiveAwareBehavior to account for NavigationPages as tabs
  • added a new NavigationPageActiveAwareBehavior to be used when you have a NavPage as a tabs in a TabbedPage. This will properly keep the active pages IsActive properties sync'd

To use, simply add the NavigationPageActiveAwareBehavior to your NavigationPage.
xmlns:b="clr-namespace:Prism.Behaviors;assembly=Prism.Forms"

	<NavigationPage Title="View A">
		<NavigationPage.Behaviors>
			<b:NavigationPageActiveAwareBehavior />
		</NavigationPage.Behaviors>
		<x:Arguments>
			<local:ViewA Title="View A" />
		</x:Arguments>
	</NavigationPage>

@ChrisJAult
Copy link

There appears to be the same issue with dynamically created tab pages. For example my nav url is app:///MasterDetailPage/TabsPage?createTab=NavigationPage|ViewA&createTab=NavigationPage|ViewB&createTab=NavigationPage|ViewC&selectedTab=ViewA
IActiveAware IsActive is not fired if I tap on tab ViewB when the app is first started

@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants