Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1338 adds IContainerProvider to OnInitialized, removes Initialize #1342

Merged
merged 1 commit into from
Jan 20, 2018
Merged

#1338 adds IContainerProvider to OnInitialized, removes Initialize #1342

merged 1 commit into from
Jan 20, 2018

Conversation

dansiegel
Copy link
Member

Description of Change

  • Removes Initialize method
  • Adds IContainerProvider to OnInitialized

Bugs Fixed

API Changes

List all API changes here (or just put None), example:

Removed:

  • IModule.Initialize()

Changed:

  • IModule.OnInitialized() => IModule.OnInitialized(IContainerProvider)

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@brianlagunas brianlagunas merged commit 7c96c9a into master Jan 20, 2018
@brianlagunas brianlagunas deleted the module-initialization branch January 20, 2018 16:36
@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dansiegel @brianlagunas